Skip to content

Include library/stdarch for CURRENT_RUSTC_VERSION updates#152188

Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
cuviper:placeholder-stdarch
Feb 15, 2026
Merged

Include library/stdarch for CURRENT_RUSTC_VERSION updates#152188
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
cuviper:placeholder-stdarch

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Feb 5, 2026 •
edited by rustbot
Loading

Our tool replace-version-placeholder uses the tidy file walker and its
directory filter, but that skips library/stdarch which we do need for public
stability markers. This PR adds a local filter function that explicitly allows
that path.

The commit for 1.94 stdarch updates is coming from beta #152187.

@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2026

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • People who recently interacted with files modified in this PR: libs
  • libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet

@cuviper
Copy link
Member Author

cuviper commented Feb 5, 2026

The tool is the most relevant part to review.

r? release

@rustbot rustbot added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Feb 5, 2026
@rustbot rustbot assigned Dylan-DPC and unassigned jhpratt Feb 5, 2026
@cuviper
Copy link
Member Author

cuviper commented Feb 5, 2026

r? emilyalbini

@rustbot rustbot assigned emilyalbini and unassigned Dylan-DPC Feb 5, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Mark-Simulacrum
Mark-Simulacrum approved these changes Feb 6, 2026
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other paths we should include for this? Maybe clippy or rustfmt or something like that?

View changes since this review

@cuviper
Copy link
Member Author

cuviper commented Feb 6, 2026

I only found one time that clippy has used this in commit 5f26d0e, which still lingers today -- that ought to be 1.88.0 I guess. I'm not sure if that version is surfaced to the user anywhere though, so I don't know if the build-time replacement is working in that context either.

I didn't find any history of CURRENT_RUSTC_VERSION in rustfmt or other tools.

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2026

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Feb 6, 2026
@cuviper
Copy link
Member Author

cuviper commented Feb 6, 2026

I just fixed that single clippy instance, but I don't think we should add that path to replace-version-placeholder unless there's something that deals with that pre-replaced too, at build time.

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Feb 14, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 14, 2026

📌 Commit 001d710 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2026
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 14, 2026
Open
@jhpratt jhpratt mentioned this pull request Feb 15, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 15, 2026
@bors
Auto merge of #152639 - jhpratt:rollup-sIUYGho, r=jhpratt
ce0bf0b 
Rollup of 9 pull requests

Successful merges:

 - #150424 (diagnostics: add note when param-env shadows global impl)
 - #152132 (implement `carryless_mul`)
 - #152508 (Improve write! and writeln! error when called without destination)
 - #152534 (Test(lib/win/net): Skip UDS tests when under Win7)
 - #152578 (ci: Lock cross toolchain version and update docs)
 - #152188 (Include `library/stdarch` for `CURRENT_RUSTC_VERSION` updates)
 - #152402 (Add regression test for #141738)
 - #152472 (unwind/wasm: fix compile error by wrapping wasm_throw in unsafe block)
 - #152610 (Exchange js_lint message between bless and non-bless)
@rust-bors rust-bors bot merged commit ef776c6 into rust-lang:main Feb 15, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 15, 2026
rust-timer added a commit that referenced this pull request Feb 15, 2026
@rust-timer
Unrolled build for #152188
fb759df 
Rollup merge of #152188 - cuviper:placeholder-stdarch, r=Mark-Simulacrum

Include `library/stdarch` for `CURRENT_RUSTC_VERSION` updates

Our tool `replace-version-placeholder` uses the `tidy` file walker and its
directory filter, but that skips `library/stdarch` which we do need for public
stability markers. This PR adds a local filter function that explicitly allows
that path.

The commit for 1.94 `stdarch` updates is coming from beta #152187.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@emilyalbini emilyalbini

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cuviper @rustbot @rust-log-analyzer @Mark-Simulacrum @emilyalbini @jhpratt @Dylan-DPC